Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Update tests to not expect trailing slash #388

Merged
merged 1 commit into from
Jan 20, 2023
Merged

MNT Update tests to not expect trailing slash #388

merged 1 commit into from
Jan 20, 2023

Conversation

GuySartorelli
Copy link
Member

silverstripe/silverstripe-framework#10538 makes various methods not include a trailing slash by default. This PR updates relevant tests to not expect trailing slashes.

Parent issue

@GuySartorelli GuySartorelli mentioned this pull request Jan 13, 2023
Closed
4 tasks
@GuySartorelli GuySartorelli marked this pull request as draft January 13, 2023 00:04
emteknetnz
emteknetnz approved these changes Jan 18, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think this needs to be a draft PR

emteknetnz
emteknetnz requested changes Jan 18, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - there's failing unit tests - I guess those will be resolved once the framework PR is merged

@GuySartorelli GuySartorelli marked this pull request as ready for review January 18, 2023 22:24
@GuySartorelli
Copy link
Member Author

Correct, it doesn't need to be draft. My bad.
Relevant failing unit tests are not failing in installer CI (see main issue)

@GuySartorelli
Copy link
Member Author

Remaining failing unit tests are unrelated.

@GuySartorelli GuySartorelli merged commit 42a17bd into silverstripe:2 Jan 20, 2023
@GuySartorelli GuySartorelli deleted the pulls/2/no-trailing-slash branch January 20, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GuySartorelli @emteknetnz