API Rescue Master Branch PR: Support new extend*() format for extension methods #371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
GuySartorelli
force-pushed
the
pulls/2/rescue-master-new-extension-functionality
branch
from
e106638 to
f7bcf58
Compare
API Remove deprecated 5.0 methods
GuySartorelli
force-pushed
the
pulls/2/rescue-master-new-extension-functionality
branch
from
efefea9 to
9eb2aee
Compare
|
Re-running tests now that dependent PR has been merged |
|
Needs silverstripe/silverstripe-asset-admin#1290 and silverstripe/silverstripe-postgresql#135 to be merged for CI to go green. |
|
Merged both, rerunning tests |
|
Still failing |
|
The current CI failure will be resolved when silverstripe/silverstripe-framework#10479 is merged (though there will likely be others after that) |
emteknetnz
approved these changes
Sep 1, 2022
emteknetnz
deleted the
pulls/2/rescue-master-new-extension-functionality
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rescues #84
Dependencies
Parent issue