FIX lookupReverseOwners to work in deriving classes #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
|
@dnsl48 do you want to target this at 1.4 (or earlier)? It's a bugfix? |
|
Could do so, but I'm not sure it's worth the risk. Even though it's a bufgix, technically it amends the method behaviour. I'd prefer it to go to the next minor release, just as a safer path to take. P.S. well, arguably it could be called an enhancement too, not strictly a bugfix :) |
|
I'm still thinking it's probably a valid bugfix. I really think that if anyone else was subclassing |
|
I've changed the base to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix allows classes extending RecursivePublishable to use
lookupReverseOwners.Currently, those aren't always explicitly registered as extensions and as such
DataObject::has_extensionmay return false even if RecursivePublishable is there, but the particular calling extension is not.DataObject::has_extensionchecks for deriving classes internally (unless a third parameter given).Related Issues
#72