WIP: FIX Filtering the version history by a specific date is now more performant in large datasets #197
Conversation
…ormant in large datasets
robbieaverill
changed the title
|
Ok this clearly isn't going to work, will need to come up with something else |
|
Good try, but I don't think the logic would be correct trying to duplicate the conditions. |
|
The tests that are failing are where the base query conditions include fields from an inner join, so the inner join for latest archived record can't use them. I also tried converting it to a subselect in a "where" condition, but that didn't have the same performance benefits. My next step will be to try and rewrite the query so it doesn't use joins at all, but I'm also happy to put this on the backburner for a while and wait for more input =) |
I think I did it wrong, which was why. I've updated the PR and pushed a new commit which correctly moved the join logic into a where condition. |
|
Still some bugs with this - will park it for now |
|
Looks like you missed one other spot in the query. I've pushed an update 🤞 |
|
Still not working 😞 |
|
Closing, not ready for peer review |
Fixes #194
cc @silverstripe/core-team