API Update method signature to match parent class #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits:
Commit 1:
Quick tidyup to use the
ignore_menuitemconfiguration property instead of removing the menu item at runtime.Can't refactor to use
AdminControllerinstead ofLeftAndMainyet because it needs formschema - but this small refactor will make that slightly easier when I come to it.Commit 2:
Reflects changes in silverstripe/silverstripe-admin#1836
Issue
admin/*routing logic fromLeftAndMaininto its own abstract class silverstripe-admin#1761