NEW display controls in a consistent manner #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a work around to embedding the HistoryViewerField within a regular edit form (such as within a GridFieldDetailForm) allow a developer to opt-in to hiding the save/publish actions, and pushing the revert button to the bottom of the CMS screen to keep actions for the current screen in the CMS consistent. This can be done by adding a class to the Tab that hosts the history viewer.
NightJar
force-pushed
the
pulls/1.0/edit-UI-history
branch
from
879fcc1 to
e0e19ac
Compare
robbieaverill
approved these changes
Jul 3, 2018
There was a problem hiding this comment.
Looks great! I would've preferred to use flexbox, but this has less of an impact on the rest of the CMS interface so nice work =)
One thing I noticed (totally unrelated) is that the pagination select box is too wide. Would you mind smashing in a .history-viewer__pagination select { width: auto } somewhere into the SCSS in this PR? I can do it later otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a work around to embedding the HistoryViewerField within a regular
edit form (such as within a GridFieldDetailForm) allow a developer to
opt-in to hiding the save/publish actions, and pushing the revert button
to the bottom of the CMS screen to keep actions for the current screen
in the CMS consistent. This can be done by adding a class to the Tab
that hosts the history viewer.
c.f. silverstripe/silverstripe-elemental#251
Resolves #22