Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Injectable GridField config components. #1330

Conversation

mfendeksilverstripe
Copy link
Contributor

@mfendeksilverstripe mfendeksilverstripe commented Sep 19, 2024

ENH: Injectable GridField config components.

Description

Allow GridField config components to be injectable so we have more configuration options.

Issues

Note

Failing tests are an upstream error, not related to this changeset.

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@michalkleiner
Copy link
Contributor

Thanks for the PR @mfendeksilverstripe, can you check if the failing test is related? There's some deprecation warnings there. Otherwise the change looks ok.

@mfendeksilverstripe
Copy link
Contributor Author

Hey @michalkleiner confirming that the broken tests are upstream error. As far as I can see they were introduced recently.

Screenshot 2024-09-20 at 7 35 56 AM

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm the CI failure is unrelated to this PR.

For future reference, the commit message shouldn't have a colon

- ENH: Injectable GridField config components.
+ ENH Injectable GridField config components.

I'm okay merging this one without that small change.

@GuySartorelli GuySartorelli merged commit a80265a into silverstripe:6 Sep 24, 2024
12 of 13 checks passed
@mfendeksilverstripe mfendeksilverstripe deleted the feature/injectable-config branch September 24, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants