Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Use GitHub Actions CI #1156

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Jul 5, 2022

Issue silverstripe/gha-ci#11

Workflow run https://github.com/creative-commoners/silverstripe-userforms/actions?query=branch%3Apulls%2F5.12%2Fmodule-standards

Setting segment-field to ^2.2 for --prefer-lowest as it's the minimum version version where it's a 'vendor-module' in composer.json rather than a 'silverstripe-module', meaning it gets loaded in to the vendor folder, so the gha-ci will delete its phpunit5 tests otherwise we get

PHP Fatal error:  Declaration of SilverStripe\Forms\Tests\SegmentFieldTest::tearDown() must be compatible with SilverStripe\Dev\SapphireTest::tearDown(): void in /home/runner/work/silverstripe-userforms/silverstripe-userforms/segment-field/tests/SegmentFieldTest.php on line 23

https://github.com/creative-commoners/silverstripe-userforms/runs/7191559893?check_suite_focus=true

@emteknetnz emteknetnz force-pushed the pulls/5.12/module-standards branch from 1fe665b to 026b365 Compare July 6, 2022 00:54
@emteknetnz emteknetnz force-pushed the pulls/5.12/module-standards branch from 026b365 to 13d6ddc Compare July 14, 2022 00:50
composer.json Show resolved Hide resolved
@GuySartorelli GuySartorelli merged commit a82a924 into silverstripe:5.12 Jul 15, 2022
@GuySartorelli GuySartorelli deleted the pulls/5.12/module-standards branch July 15, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants