Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH PHP 8.1 compatibility #89

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz marked this pull request as ready for review April 20, 2022 05:10
@GuySartorelli
Copy link
Member

Builds are failing - can you please take a look?

@emteknetnz
Copy link
Member Author

emteknetnz commented Apr 25, 2022

.travis.yml required a ^4 of webauthn, which is currently not php 8.1 compatible. I've changed to 4.x-dev, it'll still fail until https://github.com/silverstripe/silverstripe-webauthn-authenticator/pulls is merged

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For posterity: See discussion in silverstripe/silverstripe-admin#1294 about the general approach. tl;dr:

the purposes of this PR is to avoid passing null (specifically null) from built-in functions that as of php 8.1 will throw deprecation warnings if null is passed in. The approach is necessarily heavy-handed, and while there are many situations where it isn't needed, it would be prohibitively laborious to find all of those situations by hand.

Looks good to me - but @emteknetnz can you please validate that the travis build not failing is okay? Based on your previous comment it sounds like it was expected to fail?

@emteknetnz
Copy link
Member Author

Ah, might have been this older commit that was required - silverstripe/silverstripe-webauthn-authenticator@371c5bb

@GuySartorelli
Copy link
Member

Sweet. I'll add this to my merge list for this afternoon.

@GuySartorelli GuySartorelli merged commit e4dac02 into silverstripe:4 Apr 26, 2022
@GuySartorelli GuySartorelli deleted the pulls/4/php81 branch April 26, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants