Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP PHP Support in CMS5 #107

Merged
merged 1 commit into from
Jan 17, 2023
Merged

DEP PHP Support in CMS5 #107

merged 1 commit into from
Jan 17, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova commented Dec 13, 2022 •
edited
Loading

@sabina-talipova sabina-talipova mentioned this pull request Dec 13, 2022
Closed
3 tasks
@sabina-talipova
Copy link
Contributor Author

sabina-talipova commented Dec 22, 2022 •
edited by emteknetnz
Loading

Requires

@emteknetnz emteknetnz force-pushed the pulls/5/upgrade-cms5 branch from 73b52e4 to 0898e15 Compare January 17, 2023 22:28
emteknetnz
emteknetnz approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@emteknetnz emteknetnz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Behat failures will be dealt with post-beta in this issue - silverstripe/silverstripe-mfa#479

Have manually tested locally to confirm that registration + logging in + backup codes do work

@emteknetnz emteknetnz merged commit 113f966 into silverstripe:5 Jan 17, 2023
@emteknetnz emteknetnz deleted the pulls/5/upgrade-cms5 branch January 17, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @emteknetnz