ENH Add generic types (#86)

silverstripe · Jan 22, 2024 · cc43a12 · cc43a12
1 parent 4bcdf97
commit cc43a12
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/Extension/FileTextExtractable.php b/src/Extension/FileTextExtractable.php
@@ -14,6 +14,8 @@
  * Adds an additional property which is the cached contents, which is populated on demand.
  *
  * @author mstephens
+ *
+ * @extends DataExtension<File>
  */
 class FileTextExtractable extends DataExtension
 {
@@ -85,7 +87,6 @@ public function getFileContent()
      */
     public function extractFileAsText($disableCache = false)
     {
-        /** @var File $file */
         $file = $this->owner;
         if (!$disableCache) {
             $text = $this->getTextCache()->load($file);

diff --git a/src/Extractor/FileTextExtractor.php b/src/Extractor/FileTextExtractor.php
@@ -87,7 +87,6 @@ public static function for_file($file)
 
         // Ensure we have a File instance to work with
         if (is_string($file)) {
-            /** @var File $fileObject */
             $fileObject = File::create();
             $fileObject->setFromLocalFile($file);
             $file = $fileObject;