Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Add generic types #102

Merged
merged 1 commit into from
Jan 23, 2024
Merged

ENH Add generic types #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/Controllers/TaxonomyDirectoryController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
* Class TaxonomyDirectoryController
*
* Controller for returning a list of pages tagged with a specific Taxonomy Term
*
* @extends PageController<Page>
*/
class TaxonomyDirectoryController extends PageController
{
Expand Down
2 changes: 0 additions & 2 deletions src/TaxonomyTerm.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ public function onBeforeDelete()
parent::onBeforeDelete();

foreach ($this->Children() as $term) {
/** @var TaxonomyTerm $term */
$term->delete();
}
}
Expand Down Expand Up @@ -200,7 +199,6 @@ public function onAfterWrite()

// Write the current term's type to all children
foreach ($this->Children() as $term) {
/** @var TaxonomyTerm $term */
$term->TypeID = $this->Type()->ID;
$term->write();
}
Expand Down