Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Remove TODO comments #264

Merged
merged 1 commit into from
Oct 24, 2023
Merged

MNT Remove TODO comments #264

merged 1 commit into from
Oct 24, 2023

Conversation

sabina-talipova
Copy link
Contributor

sabina-talipova
sabina-talipova commented Oct 12, 2023
View reviewed changes
src/StringTagField.php
@@ -366,7 +366,7 @@ protected function getTags($term)
];
}
}
// @todo do we actually need lazy loading limits for StringTagField?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Open ticket: #263

@sabina-talipova sabina-talipova mentioned this pull request Oct 12, 2023
Closed
GuySartorelli
GuySartorelli approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 473cb53 into silverstripe:3.1 Oct 24, 2023
10 checks passed
@GuySartorelli GuySartorelli deleted the pulls/3.1/remove-todo branch October 24, 2023 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sabina-talipova @GuySartorelli