-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Added the state changed checks and bubble up event #262
FIX Added the state changed checks and bubble up event #262
Conversation
I tried to keep the PR inline as close to the branch 3 This branch (2) is using older version of react + node. |
Thank you for submitting this PR. In order for us to release this, it needs to be targetting the correct branch. The |
Thanks @GuySartorelli - Just running through the reset steps |
68300c1
to
9257956
Compare
@GuySartorelli I believe I have done that correctly.. |
Awesome, thank you. Looks correct to me. Someone will review this as time permits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Test locally, all works perfect.
Note that this should not cause regressions for:
Issue