Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Added the state changed checks and bubble up event #262

Merged

Conversation

josephlewisnz
Copy link
Contributor

@josephlewisnz josephlewisnz commented Oct 5, 2023

@josephlewisnz
Copy link
Contributor Author

I tried to keep the PR inline as close to the branch 3
https://github.com/silverstripe/silverstripe-tagfield/pull/251/files

This branch (2) is using older version of react + node.
I didn't upgrade them so the there are slight changes in the approach

@GuySartorelli
Copy link
Member

GuySartorelli commented Oct 5, 2023

Thank you for submitting this PR.

In order for us to release this, it needs to be targetting the correct branch. The 2 branch would be used if we were to release this in a new minor release, but we aren't making new minor releases for the 2.x release line.
Please retarget this PR to the 2.11 branch, and reset your commits afterwards if necessary.

@josephlewisnz josephlewisnz changed the base branch from 2 to 2.11 October 5, 2023 02:53
@josephlewisnz
Copy link
Contributor Author

Thanks @GuySartorelli - Just running through the reset steps

@josephlewisnz
Copy link
Contributor Author

@GuySartorelli I believe I have done that correctly..

@GuySartorelli
Copy link
Member

Awesome, thank you. Looks correct to me. Someone will review this as time permits.

Copy link
Contributor

@sabina-talipova sabina-talipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
Test locally, all works perfect.

@sabina-talipova sabina-talipova merged commit 3f69c0d into silverstripe:2.11 Oct 9, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants