Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API phpunit 9 support #471

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 2 times, most recently from d122146 to 9d0329e Compare October 19, 2021 01:40
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch 4 times, most recently from 6af166b to 11c7f68 Compare October 21, 2021 04:20
@emteknetnz emteknetnz marked this pull request as ready for review October 22, 2021 01:11
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 11c7f68 to 4d6135b Compare October 27, 2021 05:15
@emteknetnz emteknetnz force-pushed the pulls/2/sapphire-test-nine branch from 4d6135b to 13ab072 Compare October 27, 2021 05:24
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxime-rainville maxime-rainville merged commit 5049a5e into silverstripe:2 Nov 1, 2021
@maxime-rainville maxime-rainville deleted the pulls/2/sapphire-test-nine branch November 1, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants