Skip to content

Commit

Permalink
add segment for StaticCacheFullBuildTask
Browse files Browse the repository at this point in the history
  • Loading branch information
@wilr
wilr authored Sep 22, 2022
1 parent 8950d87 commit 2f05ec1
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/Task/StaticCacheFullBuildTask.php
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

class StaticCacheFullBuildTask extends BuildTask
{
private static $segment = 'StaticCacheFullBuildTask';

/**
* Queue up a StaticCacheFullBuildJob
* Check for startAfter param and do some sanity checking
Expand Down

3 comments on commit 2f05ec1

@GuySartorelli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wilr Why was this not a PR? Especially since this is changing behaviour that people might be relying on (URL segments might be in tests, deployment plans, etc - changing them might cause problems for some people.)
At the very least we'll want this documented in the changelog, but possibly this shouldn't even be done in the current major release line.

@GuySartorelli
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change and submit a PR instead.

@wilr
Copy link
Member Author

@wilr wilr commented on 2f05ec1 Sep 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GuySartorelli RE original documentation spec - https://github.com/silverstripe/silverstripe-staticpublishqueue/blob/5/docs/en/building_the_cache.md

Please sign in to comment.