DEP PHP Support in CMS5 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
sabina-talipova
force-pushed
the
pulls/4/upgrade-cms5
branch
from
0251c31 to
1ed2deb
Compare
|
Requires Passed tests in local environment. |
maxime-rainville
requested changes
Jan 12, 2023
| @@ -1,14 +0,0 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Not having a _config.php file at all might cause problems. From memory there's a bit in framework that won't recognise a packages is a silverstripe module if that file doesn't exist?
Just leave an empty _config.php file in place with:
<?phpThere was a problem hiding this comment.
DONE. I restored file and left message.
There was a problem hiding this comment.
The problem wasn't removing the deprecation messages. The problem was that we need a _config.php file in the root of the module ... even if it's completely empty.
There was a problem hiding this comment.
sabina-talipova
force-pushed
the
pulls/4/upgrade-cms5
branch
from
0af0cdb to
70f137e
Compare
sabina-talipova
force-pushed
the
pulls/4/upgrade-cms5
branch
from
70f137e to
d669b42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parent issue