Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Rename file to match class name #129

Merged

Conversation

emteknetnz
Copy link
Member

Fix for #127

@obj63mc
Copy link

obj63mc commented Jul 1, 2021

Just checking if this can be merged?

@emteknetnz emteknetnz force-pushed the pulls/2.3/rename-file branch from c82f807 to e7e9633 Compare July 8, 2021 21:06
@emteknetnz
Copy link
Member Author

There was a broken behat test, possibly related to the use of old travis shared config. I tried rerunning the individual build though it still uses the old config. I've just retriggered a build that will use an updated shared config by git undoing the last commit and re-commiting. It creates a new hash though the code is the same as what was approved.

@emteknetnz
Copy link
Member Author

Behat test passed on rerun

@emteknetnz emteknetnz merged commit 4747c75 into silverstripe:2.3 Jul 8, 2021
@emteknetnz emteknetnz deleted the pulls/2.3/rename-file branch July 8, 2021 21:23
@emteknetnz
Copy link
Member Author

@obj63mc I've tagged 2.3.6 and 2.4.2 for you which both contain this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants