Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Add behat to module #51

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Apr 8, 2021

Issue https://github.com/silverstripeltd/product-issues/issues/325

! important, ensure that the following travis shared provision is being added in this pull-request after things have been rebased

silverstripe/silverstripe-travis-shared:config/provision/standard-jobs-range-behat-npm.yml

key bit is -behat-npm :-)

@emteknetnz emteknetnz force-pushed the pulls/1/behat branch 2 times, most recently from b3d8fae to a8f7d54 Compare April 8, 2021 21:41
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should avoid creating new Behat feature methods when there's equivalent method in our behat extension module.

Otherwise the test look OK and travis appears to be running them as expected.

tests/behat/features/revoke.feature Show resolved Hide resolved
tests/behat/features/revoke.feature Outdated Show resolved Hide resolved
tests/behat/src/FixtureContext.php Show resolved Hide resolved
tests/behat/src/FixtureContext.php Show resolved Hide resolved
tests/behat/src/FixtureContext.php Show resolved Hide resolved
tests/behat/features/revoke.feature Outdated Show resolved Hide resolved
@maxime-rainville maxime-rainville merged commit 01d580a into silverstripe:1 Apr 12, 2021
@maxime-rainville maxime-rainville deleted the pulls/1/behat branch April 12, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants