Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't work on Windows #11

Open
sminnee opened this issue Nov 22, 2016 · 0 comments · May be fixed by #24
Open

Doesn't work on Windows #11

sminnee opened this issue Nov 22, 2016 · 0 comments · May be fixed by #24
Labels
affects/v4 complexity/medium impact/medium type/bug

Comments

@sminnee
Copy link
Member

sminnee commented Nov 22, 2016

Dylan reported these errors:

Notice: Use of undefined constant SIGINT - assumed 'SIGINT' in C:\Users\dwagstaff\work\testymctestface\ss4\vendor\silverstripe\serve\code\Server.php on line 100

Fatal error: Uncaught exception 'LogicException' with message 'Server didn't start on port 8080 for 30 seconds; something is kaput' in C:\Users\dwagstaff\work\testymctestface\ss4\vendor\silverstripe\serve\code\Server.php:87

I'll check it out on my Win box at home.
@sminnee sminnee self-assigned this Nov 22, 2016
tony13tv added a commit to tony13tv/silverstripe-serve that referenced this issue Nov 10, 2020
@tony13tv
Using exec explicitly breaks CMD compat
3f798a3 
Using `exec` doesn't work on windows as exec is not a valid CMD command. This fixes silverstripe#11. 

Also a validation for directory separator was added to mantain *nix shells. (This is actually a Symphony's `Process` class related issue)
@tony13tv tony13tv linked a pull request Nov 10, 2020 that will close this issue
Open
@sminnee sminnee removed their assignment Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/v4 complexity/medium impact/medium type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using exec explicitly breaks CMD compat tony13tv/silverstripe-serve
2 participants
@sminnee @maxime-rainville