Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Alternative ACS Base feature #67

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

NightJar
Copy link
Contributor

Document Alternative ACS Base feature. Include caveat about Silverstripe CMS 5 and forced "no trailing slash" which caught-out the test (since cherry-pick from CMS 4 branch; also fixed).

https://docs.silverstripe.org/en/5/changelogs/5.0.0/#trailing-slash

Ran DOCTOC as directed by comments.

Silverstripe CMS rebranded a few years ago - reflected this in the docs where the old style wasn't code related (capital middle S)

Include caveat about Silverstripe CMS 5 and forced "no trailing slash"
which caught-out the test (since cherry-pick from CMS 4 branch; also
fixed).

https://docs.silverstripe.org/en/5/changelogs/5.0.0/#trailing-slash

Ran DOCTOC as directed by comments.

Silverstripe CMS rebranded a few years ago - reflected this in the docs
where the old style wasn't code related (capital middle S)
@NightJar NightJar closed this Nov 5, 2024
@NightJar NightJar reopened this Nov 13, 2024
@NightJar
Copy link
Contributor Author

If this is merged before other work then it will leave the 3 branch with no failing tests.

@wilr wilr merged commit 881f5d6 into silverstripe:main Nov 13, 2024
@NightJar NightJar deleted the alternate_acs_again branch November 13, 2024 22:17
@NightJar NightJar mentioned this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants