Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update attributes extend method #52

Merged

Conversation

ishannz
Copy link
Contributor

@ishannz ishannz commented Nov 23, 2023

changes

  • Add a new hook called updateAttributes to update the $attributes
  • Limit the last chars to 12 on GUID to fix the validation error under validGuid function checking this preg_match /^[A-F0-9]{8}-[A-F0-9]{4}-[A-F0-9]{4}-[A-F0-9]{4}-[A-F0-9]{12}?$/i. According to this, the last chars should be 12

Please create a new tag after this and merge this to the master as well.

@ishannz ishannz force-pushed the pulls/update-attributes-extend-method branch from 92e8ae1 to faaeb60 Compare November 23, 2023 10:42
@ishannz ishannz force-pushed the pulls/update-attributes-extend-method branch from faaeb60 to fc648b2 Compare November 23, 2023 11:00
@ishannz ishannz changed the title Pulls/update attributes extend method Update attributes extend method Nov 23, 2023
@ishannz ishannz changed the base branch from main to 2 November 23, 2023 11:05
Copy link
Collaborator

@satrun77 satrun77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satrun77 satrun77 merged commit 8c7e33d into silverstripe:2 Nov 23, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants