Skip to content

Commit

Permalink
Ensure not to use singleton for form
Browse files Browse the repository at this point in the history
When using Injector to create a singleton constructor arguments are
ignored. This causes getForm to fail as SAMLLoginForm requires
constructor arguments.
  • Loading branch information
satrun77 committed Mar 18, 2024
1 parent 43fd2cb commit 62f2e51
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/Control/SAMLController.php
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,6 @@ public function getLogger()
*/
public function getForm()
{
return Injector::inst()->get(SAMLLoginForm::class, true, [$this, SAMLAuthenticator::class, 'LoginForm']);
return Injector::inst()->get(SAMLLoginForm::class, false, [$this, SAMLAuthenticator::class, 'LoginForm']);
}
}

0 comments on commit 62f2e51

Please sign in to comment.