make css more specific as to avoid interference #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RealMe login detail box is strongly specified by the RealMe design team. It needs to look one of three pre-defiend ways, without modifications caused by cascading rules. However the CSS supplied is not specific enough (nor perscriptive enough with the rules) to ensure that this is the case. So we can tighten this to be more robust.
madmatt
approved these changes
Oct 23, 2019
emteknetnz
pushed a commit
to creative-commoners/silverstripe-realme
that referenced
this pull request
May 13, 2022
The RealMe login detail box is strongly specified by the RealMe design team. It needs to look one of three pre-defiend ways, without modifications caused by cascading rules. However the CSS supplied is not specific enough (nor perscriptive enough with the rules) to ensure that this is the case. So we can tighten this to be more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RealMe login detail box is strongly specified by the RealMe design team. It needs to look one of three pre-defiend ways, without modifications caused by cascading rules.
However the CSS supplied is not specific enough (nor perscriptive enough with the rules) to ensure that this is the case. So we can tighten this to be more robust.