Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Explicity mark nullable parameters for PHP 8.4 #171

Merged
merged 1 commit into from
Dec 2, 2024
Merged

API Explicity mark nullable parameters for PHP 8.4 #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Authenticator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ public function getLostPasswordHandler($link)
* @param ValidationResult $result A validationresult which is either valid or contains the error message(s)
* @return Member The matched member, or null if the authentication fails
*/
public function authenticate(array $data, HTTPRequest $request, ValidationResult &$result = null)
public function authenticate(array $data, HTTPRequest $request, ?ValidationResult &$result = null)
{
try {
$this->service->enforceLogin($request);
Expand Down Expand Up @@ -189,7 +189,7 @@ public function authenticate(array $data, HTTPRequest $request, ValidationResult
* @param ValidationResult $result
* @return ValidationResult
*/
public function checkPassword(Member $member, $password, ValidationResult &$result = null)
public function checkPassword(Member $member, $password, ?ValidationResult &$result = null)
{
// No-op
}
Expand Down
2 changes: 1 addition & 1 deletion src/RealMeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,7 +907,7 @@ private function getRequestedAuthnContext()
*
* @return Auth
*/
public function getAuth(HTTPRequest $request = null)
public function getAuth(?HTTPRequest $request = null)
{
if (isset($this->auth)) {
return $this->auth;
Expand Down
Loading