Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Require phpunit ^9.6 #90

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Mar 30, 2023

Issue silverstripe/.github#34

Fixes --prefer-lowest build - https://github.com/silverstripe/silverstripe-hybridsessions/actions/runs/4559193473/jobs/8042962237#step:12:68

1) SilverStripe\HybridSessions\Tests\HybridSessionTest::testReadReturnsEmptyStringWithNoHandlers PHPUnit\Framework\MockObject\IncompatibleReturnValueException: Method read may not return value of type boolean, its return declaration is "false|string"

@GuySartorelli GuySartorelli merged commit 6bf6786 into silverstripe:3.0 Mar 31, 2023
@GuySartorelli GuySartorelli deleted the pulls/3.0/phpunit branch March 31, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants