API phpunit 9 support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93 tasks
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
4 times, most recently
from
b5623bb to
be877d9
Compare
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
be877d9 to
2fe8cd4
Compare
maxime-rainville
requested changes
Nov 1, 2021
src/Jobs/GenerateCSVJob.php
Outdated
| @@ -387,7 +387,7 @@ protected function outputRows(GridField $gridField, $columns, $start, $count) | |||
| } | |||
| } | |||
|
|
|||
| public function setup() | |||
| public function setUp() | |||
There was a problem hiding this comment.
I think this was updated by accident.
emteknetnz
force-pushed
the
pulls/2/sapphire-test-nine
branch
from
2fe8cd4 to
c35df1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/silverstripe-framework#10019