-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Migrate code and docs from other modules #596
API Migrate code and docs from other modules #596
Conversation
949baec
to
c47a600
Compare
protected function setUp(): void | ||
{ | ||
parent::setUp(); | ||
// CSRF token check is normally disabled for unit-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed because after moving the location of this test in recipe-kitchen-sink, some other test was somehow interfering with this. This just sets up the Security token so that it's in the correct state for the test, and then resets it to however it was before
010927e
to
ca71747
Compare
0ae1b20
to
a8956ea
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume those docs are all just directly copy/pasted, and haven't been altered at all?
They may need retouching when they get added back into the "other features" section but there's a separate card for that so that's okay.
0e4666b
to
fe8243f
Compare
fe8243f
to
d93e51a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM will merge when other PRs are happy
1020a68
to
39eb19e
Compare
39eb19e
to
a8c7591
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re-approved most recent changes
Issue silverstripe/silverstripe-admin#1799
Have validated that the front end schema is still usable:
composer require silverstripe/graphql-devtools
app/_config/graphql.yml
app/_graphql/models.yml
dev/build flush=1
Test using graphql devtool
https://mysite.test/dev/graphql/ide
Test a query
Test migrated versioning plugin
(Make draft changes on page ID = 2 in the CMS)
Refersh the CMS - page has been published