ENH Use class name instead of self #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
emteknetnz
force-pushed
the
pulls/5.2/remove-self
branch
2 times, most recently
from
a633602 to
63e5a1a
Compare
emteknetnz
commented
Jun 5, 2024
| return false; | ||
| } | ||
| $path = self::getRebuildOnMissingPath(); | ||
| $path = static::getRebuildOnMissingPath(); |
There was a problem hiding this comment.
This actually needs to be static, not AbstractTypeRegistry, otherwise there's a unit test failure
1) SilverStripe\GraphQL\Tests\Schema\AbstractTypeRegistryTest::testRebuildOnMissing with data set #3 (true, true, true, false, false)
Error: Cannot call abstract method SilverStripe\GraphQL\Schema\Storage\AbstractTypeRegistry::getSourceDirectory()
/var/www/vendor/silverstripe/graphql/src/Schema/Storage/AbstractTypeRegistry.php:99
/var/www/vendor/silverstripe/graphql/src/Schema/Storage/AbstractTypeRegistry.php:83
/var/www/vendor/silverstripe/graphql/tests/Schema/AbstractTypeRegistryTest.php:93
/var/www/vendor/bin/phpunit:122
63e5a1a to
fb18d9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/developer-docs#486