-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX Add test cases for SortPlugin #564
FIX Add test cases for SortPlugin #564
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have only one test validating that this sort plugin works when sorting multiple fields at once:
files(sort: { name: ASC, title: DESC }) {
Please also add one with those fields reversed, to validate that the order in which the fields are added in the query changes the actual sort order.
files(sort: { title: DESC, name: ASC }) {
Make sure this new scenario gives different results than the existing one.
b2e9018
to
94863fe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is now a bugfix, please update the commit message to use the FIX
prefix and to have a message that explains what bug is being fixed.
d7cf2eb
to
2cde1a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small change - everything else looks good.
2cde1a1
to
f929eb6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Parent issue