API Block older version module from using this minor #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I created fake releases on the creative commoners repo to test this:
I use this composer file to test. {
"name": "maxime/boom",
"type": "project",
"authors": [
{
"name": "Maxime Rainville",
"email": "[email protected]"
}
],
"minimum-stability": "dev",
"require": {
"silverstripe/graphql": "^3.4",
"silverstripe/admin": "~1.7.0"
},
"prefer-stable": true,
"repositories": [
{
"type": "vcs",
"url": "[email protected]:creative-commoners/silverstripe-graphql.git"
}
]
}I've confirmed that changing the |
|
I'll double check that the modules included the conflict require |
| @@ -8,6 +8,12 @@ | |||
| "silverstripe/vendor-plugin": "^1.0", | |||
| "webonyx/graphql-php": "~0.12.6" | |||
| }, | |||
| "conflict": { | |||
There was a problem hiding this comment.
I used the list of dependent module from packagist to determine what should show in here https://packagist.org/packages/silverstripe/graphql/dependents
I only included supported module.
There was a problem hiding this comment.
Actually, that list looks wrong. admin and versioned shouldn't be here. versioned-admin should.
emteknetnz
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 3.5 of GraphQL expects different cases for some queries. Older version of modules that depend on this module will not work with 3.5.
This PR aims to make this conflict explicit.
Parent issue