NEW: Field formatting API, forward compatibility #313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chillu
requested changes
Nov 3, 2020
There was a problem hiding this comment.
Looking good! Tested this with all the branches mentioned in #282.
Talked with Aaron, we've agreed to mark the new API surface as @internal and encourage usage of GraphQL v4 instead.
We'll want to merge this close to the time as all the other PRs, since it would break common dev usage such as silverstripe/cms:4.x-dev + silverstripe/graphql:3.x-dev usage otherwise.
chillu
reviewed
Nov 4, 2020
chillu
reviewed
Nov 4, 2020
15 tasks
chillu
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from: #310
We need backward compat for all the core modules, so they can run on either v3 or v4. It's very difficult to do this at run time because the graphql queries are bound to components at build time, so having two separate queries is both a technical challenge and also hard to maintain.
The easier solution is to allow the graphql 3 queries to look like graphql 4 queries, and the main issue there is case sensitivity.
This pull request allows the optional provision of a field formatter function and field accessor service to abstract this away. By default, you still get the naive implementation of DBField == GraphQL Field, but in admin, we'll want to take advantage of a lowerCamelCase transform.
Todo: