Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Allow graphql ^6 #52

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

emteknetnz
Copy link
Member

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need to decide how we want to handle this one - maintaining it will be easier if we don't do multi-branch support like this.

@emteknetnz
Copy link
Member Author

Why would it be easier? This PR seems easier.

@GuySartorelli
Copy link
Member

Any breaking changes in other graphql 6 may cause problems with this. It's the same reason we bump other modules like config which may not directly need it.

@emteknetnz
Copy link
Member Author

I'd say that's graphql 6 is very unlikely to break this. There hasn't been any discussion for work on GraphQL 6 so most likely scenarios is that it will be near identical to GraphQL 5

If we do run into problems at a future then we can access whether we should adapt the 1 branch of this module to add support for GraphQL 6, or if we should create a new 2 branch instead

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems weird that we're handling this one differently than everything else, when the argument was that we should just handle everything the same way... but w/e.

@GuySartorelli GuySartorelli merged commit 6bc3873 into silverstripe:1 Feb 20, 2024
9 checks passed
@GuySartorelli GuySartorelli deleted the pulls/1/cms6 branch February 20, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants