Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP PHP Support in CMS5 #335

Merged
merged 1 commit into from
Jan 16, 2023
Merged

DEP PHP Support in CMS5 #335

merged 1 commit into from
Jan 16, 2023

Conversation

sabina-talipova
Copy link
Contributor

@sabina-talipova sabina-talipova mentioned this pull request Dec 12, 2022
Closed
3 tasks
@emteknetnz
Copy link
Member

Requires a ^2 version of https://github.com/tractorcow/silverstripe-proxy-db

@sabina-talipova sabina-talipova mentioned this pull request Dec 22, 2022
Merged
@sabina-talipova sabina-talipova force-pushed the pulls/4/upgrade-cms5 branch 2 times, most recently from 32c959e to d9da854 Compare January 13, 2023 03:09
@sabina-talipova
Copy link
Contributor Author

Passed tests in local env.
Requires PR to be merged first

maxime-rainville
maxime-rainville approved these changes Jan 16, 2023
View reviewed changes
Copy link

@maxime-rainville maxime-rainville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Maybe we want to create a subsite CMS5 PR before merging this. But I'm not too fuss either way.

@sabina-talipova
Copy link
Contributor Author

DONE

@maxime-rainville maxime-rainville merged commit fc415c3 into silverstripe:4 Jan 16, 2023
@maxime-rainville maxime-rainville deleted the pulls/4/upgrade-cms5 branch January 16, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emteknetnz emteknetnz emteknetnz left review comments

@maxime-rainville maxime-rainville maxime-rainville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sabina-talipova @emteknetnz @maxime-rainville