Filter DataObjects on ShowInSearch

[emteknetnz]

This was originally branched off 3.6, have since rebased and retargeted to 3

Issue: #257

Inlet filtering - cms save
SearchUpdateProcessor.php

Inlet filtering - solr reindex
SolrReindexBase.php

Outlet filtering
SolrIndex.php

[chillu]

Good work so far! Don't forget to reflect any changes in the docs as well. For example, https://www.cwp.govt.nz/developer-docs/en/2/features/solr_search/basic_usage/ mentions using Index->search() directly, without either mentioning canView or ShowInSearch there, so setting you up for failure. As a rule of thumb, on the search results side whenever it does canView it should also check ShowInSearch.

And we should probably add some clear docs on CWP around not using the raw SolrIndex for querying unless you really know what you're doing. CWP\Search\Extensions\SearchControllerExtension does some magic, and then CwpSearchEngine does more. We should make it clear that it's the preferred, supported way of searching, no matter how horrible it might be in terms of layering.

[Cheddam]

Looking pretty solid! Agreed with @chillu on shifting one of the checks, one minor code suggestion, and have suggested some tweaks to the new documentation.

[Cheddam]

Haven't completed manual testing yet, will pick that up next, but looking pretty solid! I've suggested some further adjustments to the documentation, recommended we drop the commented placeholder canView() code, and asked for some clarity regarding the storage of the $indexableState.

[Cheddam]

Sidenote - this needs to be rebased and retargeted to the 3 branch, as it introduces new API surface.

[chillu]

Good start, left a comment below

[emteknetnz]

@Cheddam have rebased and retargeted to 3 (used to be 3.6) cos as you say, new API = minor release

feedback addressed

All feedback has been addressed.