MNT New tests classes to test version tags #160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabina-talipova
force-pushed
the
pulls/1/versioned-ui-test-objects
branch
from
c97af87 to
59ebc1d
Compare
sabina-talipova
force-pushed
the
pulls/1/versioned-ui-test-objects
branch
from
59ebc1d to
9053227
Compare
emteknetnz
requested changes
Jan 7, 2024
|
|
||
| class NonVersionedParentObject extends DataObject | ||
| { | ||
| private static $table_name = 'NonVersionedParentObject'; |
There was a problem hiding this comment.
Suggested change
| private static $table_name = 'NonVersionedParentObject'; | |
| private static $table_name = 'FrameworkTest_NonVersionedParentObject'; |
|
|
||
| class NonVersionedChildObject extends DataObject | ||
| { | ||
| private static $table_name = 'NonVersionedChildObject'; |
There was a problem hiding this comment.
Suggested change
| private static $table_name = 'NonVersionedChildObject'; | |
| private static $table_name = 'FrameworkTest_NonVersionedChildObject'; |
|
|
||
| class VersionedChildObject extends DataObject | ||
| { | ||
| private static $table_name = 'VersionedChildObject'; |
There was a problem hiding this comment.
Suggested change
| private static $table_name = 'VersionedChildObject'; | |
| private static $table_name = 'FrameworkTest_VersionedChildObject'; |
| */ | ||
| class TestPageVersionedObject extends Page implements \TestPageInterface | ||
| { | ||
| private static $table_name = 'FrameworkTestPage_VersionedObject'; |
There was a problem hiding this comment.
Suggested change
| private static $table_name = 'FrameworkTestPage_VersionedObject'; | |
| private static $table_name = 'FrameworkTest_VersionedObject'; |
|
|
||
| class VersionedParentObject extends DataObject | ||
| { | ||
| private static $table_name = 'VersionedParentObject'; |
There was a problem hiding this comment.
Suggested change
| private static $table_name = 'VersionedParentObject'; | |
| private static $table_name = 'FrameworkTest_VersionedParentObject'; |
| /** | ||
| * Parent class of all test pages | ||
| */ | ||
| class TestPageVersionedObject extends Page implements \TestPageInterface |
There was a problem hiding this comment.
Suggested change
| class TestPageVersionedObject extends Page implements \TestPageInterface | |
| class TestPageVersionedObject extends Page implements TestPageInterface |
And add use TestPageInterface; above
sabina-talipova
force-pushed
the
pulls/1/versioned-ui-test-objects
branch
from
9053227 to
f6aa59d
Compare
sabina-talipova
force-pushed
the
pulls/1/versioned-ui-test-objects
branch
from
f6aa59d to
f9bf950
Compare
|
Closing - we can reference this PR if we decide to go forward with this work in the future, pending the spike. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional classes for creating objects for testing recursive checking of changes in child classes.
Parent issue