FIX Defensively copy mocked datetime #9968
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Datetime::now()
currently returns a reference toself::$mock_now
if a mock time has been set. This means that if one callsDatetime::now()->Modify(...)
the next timeDatetime::now()
is called it will return the modified datetime rather than the original. This PR hasDatetime::now()
return a defensive copy ofself::$mock_now
so that the mock time cannot be accidentally modified and can only be changed viaDatetime::set_mock_now()