Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 04_Shortcodes.md #9947

Merged
merged 1 commit into from
May 19, 2021
Merged

Update 04_Shortcodes.md #9947

merged 1 commit into from
May 19, 2021

Conversation

chromos33
Copy link
Contributor

@chromos33 chromos33 commented May 19, 2021

Not Fixing anything just editing a Guide Page haven't found where this is built since it is in extending.
Optional Parameters need to be at the end with no non optional Tags after them. No Problem with php 7 but php 8 will throw a Fatal if the a non optional paramter is after optional Parameters i.e. "$tagName"
If $tagName is not optional then a reorder is in.. order :D

@dhensby dhensby merged commit 713a0b4 into silverstripe:4 May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants