BUG fieldNameError() references invalid $this->form

[christopherdarling]

FieldList references $this->form which doesn't exist from what I can see. I presume this should have been $field->getForm().

However, please note that I came across this when looking for something unrelated and haven't tested this PR.

[GuySartorelli]

There definitely isn't a $this->form but there also isn't a getForm() method... I think some more thought needs to go into what's actually happening here. We may not even need this part of the code, but if we do, we need to rethink what it's meant to do exactly and whether we even want a reference to the form a fieldlist belongs to.

[kinglozzer]

There definitely isn't a $this->form but there also isn't a getForm() method

There is on FormField:

silverstripe-framework/src/Forms/FormField.php

Lines 853 to 861 in f1e5c72

	/**
	* Get the currently used form.
	*
	* @return Form
	*/
	public function getForm()
	{
	return $this->form;
	}

This is just to include the form name in the “I noticed a field name X appears twice” error message, I just tested this patch and it seems to work fine:

[Emergency] Uncaught RuntimeException: SilverStripe\Forms\{closure}() I noticed that a field called 'Title' appears twice in your 'SilverStripe\Forms\Form' form called 'SearchForm'

[GuySartorelli]

Ahhh yup I didn't notice $this was swapped out for $field.