Move hasEmptySchema and emptyString to DataSchema on SingleSelectField #9894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michalkleiner Yes I believe it is still needed. These changes work on fixing the Schema. Where as #9893 looks to be a 'workaround' for this issue. So #9893 fixes "Boolean not behaving properly in searchableFields.". However the underlying cause of this issue is fixed in this PR. |
|
Who should we poke to have this looked at? |
|
@maxime-rainville could you have a look or delegate to someone, please? |
emteknetnz
approved these changes
Jan 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema settings were being set in the state, but not in the Schema itself. Moving the
hasEmptySchemaandemptyStringschema settings to a SchemaData ensures they are created with the FormBuilder while state still tracks current value.Fixes: #8691