API: Remove TextParser and BBCodeParser

ORM/FieldType/DBText.php

@@ -9,7 +9,6 @@
 use SilverStripe\Forms\NullableField;
 use SilverStripe\Forms\TextField;
 use SilverStripe\ORM\DB;
-use SilverStripe\View\Parsers\TextParser;
 use InvalidArgumentException;
 
 /**
@@ -233,24 +232,6 @@ public function ContextSummary(
 		return $summary;
 	}
 
-	/**
-	 * Allows a sub-class of TextParser to be rendered.
-	 *
-	 * @see TextParser for implementation details.
-	 * @param string $parser Class name of parser (Must extend {@see TextParser})
-	 * @return DBField Parsed value in the appropriate type
-	 */
-	public function Parse($parser) {
-		$reflection = new \ReflectionClass($parser);
-		if($reflection->isAbstract() || !$reflection->isSubclassOf('SilverStripe\\View\\Parsers\\TextParser')) {
-			throw new InvalidArgumentException("Invalid parser {$parser}");
-		}
-
-		/** @var TextParser $obj */
-		$obj = Injector::inst()->createWithArgs($parser, [$this->forTemplate()]);
-		return $obj->parse();
-	}
-
 	public function scaffoldFormField($title = null, $params = null) {
 		if(!$this->nullifyEmpty) {
 			// Allow the user to select if it's null instead of automatically assuming empty string is

composer.json

@@ -45,14 +45,10 @@
       "SilverStripe\\Security\\": "Security/",
       "SilverStripe\\View\\": "View/"
     },
-    "psr-0": {
-      "HTML_": "thirdparty/HTML_BBCodeParser2"
-    },
     "files": ["Core/Constants.php"],
     "classmap": ["tests/behat/features/bootstrap"]
   },
   "include-path": [
-      "thirdparty/",
-      "thirdparty/HTML_BBCodeParser2/"
+      "thirdparty/"
   ]
 }

docs/en/04_Changelogs/4.0.0.md

@@ -817,6 +817,8 @@ specific functions.
 * `RestfulService` has been removed. Use Guzzle instead. See Upgrading notes.
 * Our self-maintained `Oembed` implementation has been removed, in favour of introducing
   [oscarotero/Embed](https://github.com/oscarotero/Embed) as a dependency.
+* Removed TextParser and BBCodeParser. These are available in an archived module,
+  [silverstripe-archive/bbcodeparser](https://github.com/silverstripe-archive/silverstripe-bbcodeparser)
 
 #### <a name="overview-general-deprecated"></a>General and Core Deprecated API
 

tests/model/DBHTMLTextTest.php

@@ -411,21 +411,6 @@ public function testShortcodesProcessed()
 		);
 	}
 
-	public function testParse() {
-		// Test parse
-		/** @var DBHTMLText $obj */
-		$obj = DBField::create_field(
-			'HTMLText',
-			'<p>[b]Some content[/b] [test_shortcode] with shortcode</p>'
-		);
-
-		// BBCode strips HTML and applies own formatting
-		$this->assertEquals(
-			'<strong>Some content</strong> shortcode content with shortcode',
-			$obj->Parse('SilverStripe\\View\\Parsers\\BBCodeParser')->forTemplate()
-		);
-	}
-
 	function testExists() {
 		$h = new DBHTMLText();
 		$h->setValue("");