FIX for #4417: Ensuring ->removeValidation() is defined on instances of Validator. #4418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n instances of Validator.
|
This can't go in 3.1 as it is going to cause errors for anyone who has extended the base Validator but hasn't implemented that function. I think the fix for 3.1 should be to check the method exists on validator before calling it. Probably the same for 3. Then master can have this change |
|
Please re-open a new PR for this branch on master, ta! |
|
Can a core member her this in master if we don't see this opened by the original author? |
|
Hello visitors from the future! New PR is here: #4542 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #4417. Went ahead and based this on
3.1.Might cause some issues for people who haven't defined this method and happen to also not actually need it, even though they're still technically at risk of a fatal error if that method is called in the future, should they ever have a validated form which is also not editable.