Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Anonymous function use statements in text collector #11455

Merged

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz changed the title FIX Anonymous function use statementsin text collector FIX Anonymous function use statements in text collector Nov 4, 2024
@emteknetnz emteknetnz marked this pull request as ready for review November 4, 2024 23:08
src/i18n/TextCollection/i18nTextCollector.php Outdated Show resolved Hide resolved
src/i18n/TextCollection/i18nTextCollector.php Outdated Show resolved Hide resolved
Comment on lines +627 to +628
// minus 2 is used so the the line we get corresponds with what number token_get_all() returned
$line = $lines[$lineNo - 2] ?? '';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't find any documentation about this but I'll assume it's correct

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit 84c09fd into silverstripe:5.3 Nov 5, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.3/fix-i18n branch November 5, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants