Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Do not output core code deprecation messages by default #11429

Merged

Conversation

emteknetnz
Copy link
Member

Issue #11428

@emteknetnz emteknetnz mentioned this pull request Oct 16, 2024
4 tasks
@emteknetnz emteknetnz force-pushed the pulls/5/core-deprecation branch 2 times, most recently from 6f9be23 to be0d305 Compare October 16, 2024 05:38
@emteknetnz emteknetnz marked this pull request as ready for review October 16, 2024 05:46
@emteknetnz emteknetnz force-pushed the pulls/5/core-deprecation branch 3 times, most recently from 95b873f to 9cc0071 Compare October 16, 2024 06:15
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
tests/php/Dev/DeprecationTest.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
src/Dev/Deprecation.php Outdated Show resolved Hide resolved
@emteknetnz emteknetnz force-pushed the pulls/5/core-deprecation branch 2 times, most recently from bd45c79 to b4f6fbf Compare October 17, 2024 21:57
@GuySartorelli
Copy link
Member

Bunch of stuff above still not done?

@emteknetnz emteknetnz force-pushed the pulls/5/core-deprecation branch from b4f6fbf to 7401bcf Compare October 20, 2024 21:20
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just rerunning CI

@GuySartorelli GuySartorelli merged commit 82b0851 into silverstripe:5 Oct 21, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/core-deprecation branch October 21, 2024 00:57
@emteknetnz emteknetnz mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants