-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH Do not output core code deprecation messages by default #11429
Merged
GuySartorelli
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/core-deprecation
Oct 21, 2024
Merged
ENH Do not output core code deprecation messages by default #11429
GuySartorelli
merged 1 commit into
silverstripe:5
from
creative-commoners:pulls/5/core-deprecation
Oct 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
force-pushed
the
pulls/5/core-deprecation
branch
2 times, most recently
from
October 16, 2024 05:38
6f9be23
to
be0d305
Compare
emteknetnz
force-pushed
the
pulls/5/core-deprecation
branch
3 times, most recently
from
October 16, 2024 06:15
95b873f
to
9cc0071
Compare
GuySartorelli
requested changes
Oct 16, 2024
emteknetnz
force-pushed
the
pulls/5/core-deprecation
branch
from
October 16, 2024 22:53
9cc0071
to
d953266
Compare
emteknetnz
force-pushed
the
pulls/5/core-deprecation
branch
2 times, most recently
from
October 17, 2024 02:39
e507d85
to
a1f7337
Compare
GuySartorelli
requested changes
Oct 17, 2024
emteknetnz
force-pushed
the
pulls/5/core-deprecation
branch
2 times, most recently
from
October 17, 2024 21:57
bd45c79
to
b4f6fbf
Compare
Bunch of stuff above still not done? |
emteknetnz
force-pushed
the
pulls/5/core-deprecation
branch
from
October 20, 2024 21:20
b4f6fbf
to
7401bcf
Compare
GuySartorelli
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM just rerunning CI
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11428