Various deprecations and a few features #11365
Conversation
src/Core/CoreKernel.php
Outdated
There was a problem hiding this comment.
I can't think of a way to unit test this, unfortunately, since the kernel gets booted as part of unit tests before we get a chance to set this
| protected function getRegisteredController($baseUrlPart) | ||
| { | ||
| Deprecation::notice('5.4.0', 'Will be removed without equivalent functionality to replace it'); |
There was a problem hiding this comment.
Need to wrap in withNotReplacement()
There was a problem hiding this comment.
Why? It's not called from anywhere?
| public function __construct() | ||
| { | ||
| parent::__construct(); | ||
| Deprecation::notice('5.4.0', 'Will be replaced with symfony/console commands', Deprecation::SCOPE_CLASS); |
There was a problem hiding this comment.
Need to wrap in withNoReplacement as there's no replacement in CMS 5
There was a problem hiding this comment.
Why? We don't use this anywhere?
| /** | ||
| * Get the amount of time inbetween two datetimes. | ||
| */ | ||
| public static function getTimeBetween(DBDateTime $from, DBDateTime $to): string |
There was a problem hiding this comment.
Please see the PR description
| * | ||
| * @deprecated 5.4.0 Will be replaced with SilverStripe\Dev\Command\DbBuild::lastBuilt() | ||
| */ | ||
| public static function lastBuilt() | ||
| { | ||
| Deprecation::withNoReplacement(function () { | ||
| Deprecation::notice( | ||
| '5.4.0', | ||
| 'Will be replaced with SilverStripe\Dev\Command\DbBuild::lastBuilt()' | ||
| ); | ||
| }); | ||
|
|
There was a problem hiding this comment.
| * | |
| * @deprecated 5.4.0 Will be replaced with SilverStripe\Dev\Command\DbBuild::lastBuilt() | |
| */ | |
| public static function lastBuilt() | |
| { | |
| Deprecation::withNoReplacement(function () { | |
| Deprecation::notice( | |
| '5.4.0', | |
| 'Will be replaced with SilverStripe\Dev\Command\DbBuild::lastBuilt()' | |
| ); | |
| }); | |
| */ | |
| public static function lastBuilt() | |
| { |
Class is already deprecated and method name will be the same
There was a problem hiding this comment.
This is a static method. It's possible to call this method without instantiating the class, which means we need a deprecation warning in the method itself.
| @@ -55,9 +59,22 @@ class DatabaseAdmin extends Controller | |||
|
|
|||
| /** | |||
| * Config setting to enabled/disable the display of record counts on the dev/build output | |||
| * @deprecated 5.4.0 Will be replaced with SilverStripe\Dev\Command\DbBuild.show_record_counts | |||
There was a problem hiding this comment.
| * @deprecated 5.4.0 Will be replaced with SilverStripe\Dev\Command\DbBuild.show_record_counts |
Class is already deprecated and property is the same name
There was a problem hiding this comment.
Discussion can be in #11365 (comment) given config is effectively the same as a static method.
| @@ -38,6 +41,7 @@ class DatabaseAdmin extends Controller | |||
|
|
|||
| /** | |||
| * Obsolete classname values that should be remapped in dev/build | |||
| * @deprecated 5.4.0 Will be replaced with SilverStripe\Dev\Command\DbBuild.classname_value_remapping | |||
There was a problem hiding this comment.
| * @deprecated 5.4.0 Will be replaced with SilverStripe\Dev\Command\DbBuild.classname_value_remapping |
Class is already deprecated and property is the same name
There was a problem hiding this comment.
Discussion can be in #11365 (comment)
GuySartorelli
force-pushed
the
pulls/5/cms5-for-sakesymfony
branch
from
9ebfe7c
to
dbe567d
Compare
GuySartorelli
force-pushed
the
pulls/5/cms5-for-sakesymfony
branch
from
dbe567d
to
b621cae
Compare
|
Rebased to resolve conflict |
The commits in this PR are intentionally separated, do not squash.
DatabaselessKerneland merge that functionality intoCoreKernelinstead - and addBaseKernel::getBooted()(see src/Cli/Sake.php)ArrayLib(see src/Cli/LegacyParamArgvInput.php)DBDateTime(see src/Dev/BuildTask.php)Makes sense to add the non-API-breaking new features into this minor instead of having it in the 6 PR.
Issues