Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP Use symfony for IPUtils #11344

Merged

Conversation

emteknetnz
Copy link
Member

Issue #10846

IPUtilsTest will still pass if you simply swap out the Silverstripe import of IPUtils for the Symfony one

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add Deprecation::withNoReplacement around the calls to these methods in the unit tests for IPUtils.

Please also add an entry to the 5.3 changelog saying this class has been deprecated, and to use the symfony one instead.

@emteknetnz emteknetnz force-pushed the pulls/5/use-symfony branch from b2789d1 to 16a8132 Compare August 19, 2024 21:25
@emteknetnz
Copy link
Member Author

emteknetnz commented Aug 19, 2024

Updated

Have linked changelog PR in main issue

Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GuySartorelli GuySartorelli merged commit bf46ff9 into silverstripe:5 Aug 19, 2024
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5/use-symfony branch August 19, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants