Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX Clear table logic for MySQL 8 #11319

Merged
merged 1 commit into from
Aug 6, 2024
Merged

FIX Clear table logic for MySQL 8 #11319

merged 1 commit into from
Aug 6, 2024

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz commented Aug 5, 2024 •
edited
Loading

Issue #11311

@emteknetnz emteknetnz mentioned this pull request Aug 5, 2024
Closed
@emteknetnz emteknetnz force-pushed the pulls/5.2/clear-table branch from adc0533 to 65b6fa0 Compare August 5, 2024 05:10
@emteknetnz emteknetnz force-pushed the pulls/5.2/clear-table branch from 65b6fa0 to c3f0104 Compare August 6, 2024 03:20
GuySartorelli
GuySartorelli reviewed Aug 6, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test this on one of the CI that was failing previously, e.g. silverstripe/admin behat?

@emteknetnz
Copy link
Member Author

emteknetnz commented Aug 6, 2024 •
edited
Loading

Yes - https://github.com/creative-commoners/silverstripe-elemental/actions/runs/10259038744

Previously job5 + job6 were failing on mysql80 only

GuySartorelli
GuySartorelli approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comment was a good idea.
CI failure unrelated and already resolved on the target branch.

@GuySartorelli GuySartorelli merged commit 3a36665 into silverstripe:5.2 Aug 6, 2024
13 of 14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/5.2/clear-table branch August 6, 2024 04:17
@GuySartorelli GuySartorelli mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli