ENH Auto-scaffold Member and Group with appropriate form fields #11285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
emteknetnz
requested changes
Jun 21, 2024
There was a problem hiding this comment.
I ran all the PRs against recipe-kitchen-sink CMS 6 in CI - seems like a lot of failures, https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/9605560072/job/26501273469 - I also did a subsequent kitchen-sink CMS 6 in CI without any PRs and it went green - https://github.com/emteknetnz/recipe-kitchen-sink/actions/runs/9591494828
There are more failures then I would expect, so possibly I've done something wrong though it's no immediately obivous to be - could you have a check on some of the failures and see if you can work out what's going on?
|
Fixed the one issue that seemed legitimate, now running a new sink run. Link in issue. |
emteknetnz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue