Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve DataList and ArrayList docblock comments for PHPStorm #11263

Merged
merged 1 commit into from
May 30, 2024

Conversation

MasonD
Copy link
Contributor

@MasonD MasonD commented May 23, 2024

addresses #11247 Docblock comments on DataList shadow SS_List's more useful PHPDoc types in PHPStorm (::first, ::byID, ::find, ::filter, etc.)

Copy link
Member

@kinglozzer kinglozzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and confirmed it fixes PHPStorm

@kinglozzer kinglozzer requested a review from emteknetnz May 24, 2024 15:40
@kinglozzer
Copy link
Member

@emteknetnz could I ask you to quickly copy + paste the updated files into a 5.x project and check VSCode still works correctly? Thanks

@emteknetnz emteknetnz merged commit 9546450 into silverstripe:5.2 May 30, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants