Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Allow double dots in path when not attempting directory traversal #11219

Conversation

GuySartorelli
Copy link
Member

@GuySartorelli GuySartorelli commented May 5, 2024

Description

Doesn't throw an exception for .. in a filename in scenarios that can't trigger directory traversal.

This allows, for example, images with .. in the filename to be uploaded.

Issues

Copy link
Member

@emteknetnz emteknetnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emteknetnz emteknetnz merged commit a92baea into silverstripe:5.2 May 6, 2024
15 checks passed
@emteknetnz emteknetnz deleted the pulls/5.2/less-aggressive-doubledot-check branch May 6, 2024 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants